Bug 156927 - Web Inspector: Include columnNumber in event listener locations
Summary: Web Inspector: Include columnNumber in event listener locations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-22 13:49 PDT by Joseph Pecoraro
Modified: 2016-04-22 17:44 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.25 KB, patch)
2016-04-22 13:54 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-22 13:49:08 PDT 
* SUMMARY
Include columnNumber in event listener locations.

This is needed in minified code to jump to accurate locations.
Comment 1 Radar WebKit Bug Importer 2016-04-22 13:49:31 PDT 
<rdar://problem/25884584>
Comment 2 Joseph Pecoraro 2016-04-22 13:54:14 PDT 
Created attachment 277096 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-04-22 14:11:58 PDT 
Comment on attachment 277096 [details]
[PATCH] Proposed Fix

No test coverage? :(
Comment 4 BJ Burg 2016-04-22 16:52:55 PDT 
Comment on attachment 277096 [details]
[PATCH] Proposed Fix

r=me

This is a reminder to file a bug somewhere about adding test coverage for event listener locations.
Comment 5 WebKit Commit Bot 2016-04-22 17:44:24 PDT 
Comment on attachment 277096 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 277096

Committed r199940: <http://trac.webkit.org/changeset/199940>
Comment 6 WebKit Commit Bot 2016-04-22 17:44:28 PDT 
All reviewed patches have been landed.  Closing bug.