Bug 156909 - Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
Summary: Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 156844
  Show dependency tree / graph
 
Reported: 2016-04-22 05:54 PDT by youenn fablet
Modified: 2016-04-24 05:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (17.43 KB, patch)
2016-04-22 06:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-04-22 05:54:49 PDT 
Drop [UsePointersEvenForNonNullableObjectArguments] from WebGLRenderingContext
Comment 1 youenn fablet 2016-04-22 06:08:41 PDT 
Created attachment 277054 [details]
Patch
Comment 2 youenn fablet 2016-04-22 06:10:57 PDT 
(In reply to comment #1)
> Created attachment 277054 [details]
> Patch

Patch marks a lot of parameters as nullable.
That seems a bit strange to me but this seems consistent with the spec and what Gecko and Chrome are doing.
Comment 3 Chris Dumez 2016-04-22 09:44:32 PDT 
Comment on attachment 277054 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2016-04-24 05:44:43 PDT 
Comment on attachment 277054 [details]
Patch

Clearing flags on attachment: 277054

Committed r199962: <http://trac.webkit.org/changeset/199962>
Comment 5 WebKit Commit Bot 2016-04-24 05:44:47 PDT 
All reviewed patches have been landed.  Closing bug.