Bug 156899 – Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack.

[youenn fablet]

Created attachment 277028 [details]
Patch

[Chris Dumez]

Comment on attachment 277028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277028&action=review

r=me with nit

> Source/WebCore/html/track/TextTrack.idl:43
>      readonly attribute TextTrackCueList cues;

Since we are passing by, could we mark this one as nullable to match the spec (no behavior change)

> Source/WebCore/html/track/TextTrack.idl:44
>      readonly attribute TextTrackCueList activeCues;

Since we are passing by, could we mark this one as nullable to match the spec (no behavior change)

[youenn fablet]

(In reply to comment #2)
> Comment on attachment 277028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277028&action=review
> 
> r=me with nit
> 
> > Source/WebCore/html/track/TextTrack.idl:43
> >      readonly attribute TextTrackCueList cues;
> 
> Since we are passing by, could we mark this one as nullable to match the
> spec (no behavior change)
> 
> > Source/WebCore/html/track/TextTrack.idl:44
> >      readonly attribute TextTrackCueList activeCues;
> 
> Since we are passing by, could we mark this one as nullable to match the
> spec (no behavior change)

Thanks for the review.
I'll check this and update patch accordingly.

[youenn fablet]

Created attachment 277238 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 277238 [details]
Patch for landing

Clearing flags on attachment: 277238

Committed r199986: <http://trac.webkit.org/changeset/199986>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.