Bug 156899 - Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
Summary: Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 156844
  Show dependency treegraph
 
Reported: 2016-04-22 02:17 PDT by youenn fablet
Modified: 2016-04-25 03:26 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2016-04-22 02:20 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (2.50 KB, patch)
2016-04-25 02:25 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-04-22 02:17:48 PDT
Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack.
Comment 1 youenn fablet 2016-04-22 02:20:28 PDT
Created attachment 277028 [details]
Patch
Comment 2 Chris Dumez 2016-04-22 09:46:55 PDT
Comment on attachment 277028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277028&action=review

r=me with nit

> Source/WebCore/html/track/TextTrack.idl:43
>      readonly attribute TextTrackCueList cues;

Since we are passing by, could we mark this one as nullable to match the spec (no behavior change)

> Source/WebCore/html/track/TextTrack.idl:44
>      readonly attribute TextTrackCueList activeCues;

Since we are passing by, could we mark this one as nullable to match the spec (no behavior change)
Comment 3 youenn fablet 2016-04-24 04:52:37 PDT
(In reply to comment #2)
> Comment on attachment 277028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277028&action=review
> 
> r=me with nit
> 
> > Source/WebCore/html/track/TextTrack.idl:43
> >      readonly attribute TextTrackCueList cues;
> 
> Since we are passing by, could we mark this one as nullable to match the
> spec (no behavior change)
> 
> > Source/WebCore/html/track/TextTrack.idl:44
> >      readonly attribute TextTrackCueList activeCues;
> 
> Since we are passing by, could we mark this one as nullable to match the
> spec (no behavior change)

Thanks for the review.
I'll check this and update patch accordingly.
Comment 4 youenn fablet 2016-04-25 02:25:55 PDT
Created attachment 277238 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-04-25 03:26:28 PDT
Comment on attachment 277238 [details]
Patch for landing

Clearing flags on attachment: 277238

Committed r199986: <http://trac.webkit.org/changeset/199986>
Comment 6 WebKit Commit Bot 2016-04-25 03:26:35 PDT
All reviewed patches have been landed.  Closing bug.