Bug 156885 - FTL should handle exceptions in operationInOptimize
Summary: FTL should handle exceptions in operationInOptimize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-21 17:30 PDT by Keith Miller
Modified: 2016-04-21 19:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2016-04-21 17:35 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (8.26 KB, patch)
2016-04-21 17:37 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (10.65 KB, patch)
2016-04-21 17:50 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (10.80 KB, patch)
2016-04-21 18:16 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (16.15 KB, patch)
2016-04-21 18:28 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-04-21 17:30:21 PDT 
FTL should handle exceptions in operationInOptimize
Comment 1 Keith Miller 2016-04-21 17:35:16 PDT 
Created attachment 276986 [details]
Patch
Comment 2 Keith Miller 2016-04-21 17:37:44 PDT 
Created attachment 276987 [details]
Patch
Comment 3 Keith Miller 2016-04-21 17:50:45 PDT 
Created attachment 276989 [details]
Patch
Comment 4 Keith Miller 2016-04-21 18:16:32 PDT 
Created attachment 276992 [details]
Patch
Comment 5 Michael Saboff 2016-04-21 18:18:45 PDT 
Comment on attachment 276992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276992&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        For some reasone we didn't handle any exceptions in when we called

Extra "in"?
Comment 6 Saam Barati 2016-04-21 18:22:02 PDT 
r=me too
Comment 7 Keith Miller 2016-04-21 18:28:14 PDT 
Created attachment 276994 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-04-21 19:27:41 PDT 
Comment on attachment 276994 [details]
Patch for landing

Clearing flags on attachment: 276994

Committed r199863: <http://trac.webkit.org/changeset/199863>
Comment 9 WebKit Commit Bot 2016-04-21 19:27:46 PDT 
All reviewed patches have been landed.  Closing bug.