Bug 156872 - PolymorphicAccess adds sizeof(CallerFrameAndPC) rather than subtracting it when calculating stack height
Summary: PolymorphicAccess adds sizeof(CallerFrameAndPC) rather than subtracting it wh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-21 14:57 PDT by Filip Pizlo
Modified: 2016-04-21 15:11 PDT (History)
5 users (show)

See Also:

Attachments
the patch (1.96 KB, patch)
2016-04-21 15:00 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-21 14:57:24 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-04-21 15:00:40 PDT 
Created attachment 276966 [details]
the patch
Comment 2 WebKit Commit Bot 2016-04-21 15:02:38 PDT 
Attachment 276966 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:995:  Declaration has space between type name and * in numberOfRegsForCall * sizeof  [whitespace/declaration] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2016-04-21 15:06:06 PDT 
Comment on attachment 276966 [details]
the patch

r=me
Comment 4 Filip Pizlo 2016-04-21 15:11:44 PDT 
Landed in http://trac.webkit.org/changeset/199837