RESOLVED FIXED 156861
Stop using ApplicationCacheStorage::singleton() on Windows 
https://bugs.webkit.org/show_bug.cgi?id=156861
Summary Stop using ApplicationCacheStorage::singleton() on Windows
Anders Carlsson
Reported 2016-04-21 13:02:47 PDT
Stop using ApplicationCacheStorage::singleton() on Windows
Attachments
Patch (5.61 KB, patch)
2016-04-21 13:06 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (5.84 KB, patch)
2016-04-21 13:36 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-04-21 13:06:49 PDT
Created attachment 276945 [details] Patch
Anders Carlsson
Comment 2 2016-04-21 13:36:11 PDT
Created attachment 276952 [details] Patch
Darin Adler
Comment 3 2016-04-21 13:46:08 PDT
Comment on attachment 276952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276952&action=review > Source/WebKit/win/WebApplicationCache.cpp:66 > + RetainPtr<CFPropertyListRef> cacheDirectoryPreference = adoptCF(CFPreferencesCopyAppValue(WebKitLocalCacheDefaultsKey, kCFPreferencesCurrentApplication)); Use auto here? > Source/WebKit/win/WebApplicationCache.cpp:67 > + if (cacheDirectoryPreference && (CFStringGetTypeID() == CFGetTypeID(cacheDirectoryPreference.get()))) Remove extra () here?
Anders Carlsson
Comment 4 2016-04-21 14:16:41 PDT
Committed r199836: <http://trac.webkit.org/changeset/199836>
Note You need to log in before you can comment on or make changes to this bug.