Bug 156861 - Stop using ApplicationCacheStorage::singleton() on Windows
Summary: Stop using ApplicationCacheStorage::singleton() on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-21 13:02 PDT by Anders Carlsson
Modified: 2016-04-21 14:16 PDT (History)
0 users

See Also:

Attachments
Patch (5.61 KB, patch)
2016-04-21 13:06 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (5.84 KB, patch)
2016-04-21 13:36 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-04-21 13:02:47 PDT 
Stop using ApplicationCacheStorage::singleton() on Windows
Comment 1 Anders Carlsson 2016-04-21 13:06:49 PDT 
Created attachment 276945 [details]
Patch
Comment 2 Anders Carlsson 2016-04-21 13:36:11 PDT 
Created attachment 276952 [details]
Patch
Comment 3 Darin Adler 2016-04-21 13:46:08 PDT 
Comment on attachment 276952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276952&action=review

> Source/WebKit/win/WebApplicationCache.cpp:66
> +    RetainPtr<CFPropertyListRef> cacheDirectoryPreference = adoptCF(CFPreferencesCopyAppValue(WebKitLocalCacheDefaultsKey, kCFPreferencesCurrentApplication));

Use auto here?

> Source/WebKit/win/WebApplicationCache.cpp:67
> +    if (cacheDirectoryPreference && (CFStringGetTypeID() == CFGetTypeID(cacheDirectoryPreference.get())))

Remove extra () here?
Comment 4 Anders Carlsson 2016-04-21 14:16:41 PDT 
Committed r199836: <http://trac.webkit.org/changeset/199836>