Bug 156857 – [iOS] <a ping> and <area ping> tests time out

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

Tests added with <https://trac.webkit.org/changeset/199822> time out

Regressions: Unexpected timeouts (4)
  http/tests/navigation/ping-attribute/area-cookie.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-cross-origin-from-https.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-cross-origin.html [ Timeout ]
  http/tests/navigation/ping-attribute/area-same-origin.html [ Timeout ]

<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/5039>

[Ryan Haddad]

Skipped tests in http://trac.webkit.org/projects/webkit/changeset/199826

[Daniel Bates]

Created attachment 276949 [details]
Layout Tests

Speculative patch.

[Darin Adler]

Comment on attachment 276949 [details]
Layout Tests

View in context: https://bugs.webkit.org/attachment.cgi?id=276949&action=review

> LayoutTests/http/tests/navigation/ping-attribute/resources/utilities.js:39
> +    if (testRunner.runUIScript && window.TouchEvent)

Why the window.TouchEvent check? So non-obvious that I think it needs a comment explaining the rationale. Also might want to do '"TouchEvent" in window' instead.

[Build Bot]

Comment on attachment 276949 [details]
Layout Tests

Attachment 276949 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1197941

New failing tests:
http/tests/navigation/ping-attribute/anchor-same-origin.html
http/tests/navigation/ping-attribute/area-same-origin.html
http/tests/navigation/ping-attribute/area-cross-origin.html
http/tests/navigation/ping-attribute/anchor-cross-origin.html
http/tests/navigation/ping-attribute/anchor-cookie.html
http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html
http/tests/navigation/ping-attribute/area-cookie.html
http/tests/navigation/ping-attribute/area-cross-origin-from-https.html

[Build Bot]

Created attachment 276960 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Daniel Bates]

Created attachment 286473 [details]
Patch and Layout Test

[Daniel Bates]

Created attachment 286484 [details]
Patch and Layout Test

[Build Bot]

Comment on attachment 286484 [details]
Patch and Layout Test

Attachment 286484 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1901015

New failing tests:
http/tests/navigation/ping-attribute/anchor-same-origin.html
http/tests/navigation/ping-attribute/area-same-origin.html
http/tests/navigation/ping-attribute/area-cross-origin.html
http/tests/navigation/ping-attribute/anchor-cross-origin.html
http/tests/navigation/ping-attribute/anchor-cookie.html
http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html
http/tests/navigation/ping-attribute/area-cookie.html
http/tests/navigation/ping-attribute/area-cross-origin-from-https.html

[Build Bot]

Created attachment 286497 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Daniel Bates]

(In reply to comment #9)
> Created attachment 286497 [details]
> Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

All of these tests pass on my local machine. I'm going to land this patch and watch the bots.

Additional remarks:

The EWS failure log looks weird for ios-sim. Looking at <https://webkit-queues.webkit.org/results/1901174>, run-webkit-tests error'ed out twice "Failed to run "['Tools/Scripts/run-webkit-tests', '--release', '--ios-simulator', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet', '--skip-failing-tests']" exit_code: 8". And these error messages are interspersed between the output of a layout test run o_O.

[Daniel Bates]

Committed r204720: <http://trac.webkit.org/changeset/204720>

[Daniel Bates]

Fixed JavaScript TypeErrors in <https://trac.webkit.org/changeset/204731>.
As it turns out the tests do not run in WebKit2 for iOS when built with the public iOS SDK because touch events are not supported. Skipped the tests in <https://trac.webkit.org/changeset/204738>.