Bug 156856 - AX: Media controls are operable but not visible after returning from Full Screen Mode
Summary: AX: Media controls are operable but not visible after returning from Full Scr...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 9
Hardware: iPhone / iPad iOS 9.3
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-21 11:49 PDT by Aaron Chu
Modified: 2016-05-13 08:52 PDT (History)
1 user (show)

See Also:


Attachments
an analysis of the makeup for the media controls. (5.95 KB, text/html)
2016-04-21 11:49 PDT, Aaron Chu
no flags Details
Patch (3.53 KB, patch)
2016-05-09 01:24 PDT, Aaron Chu
cfleizach: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Chu 2016-04-21 11:49:27 PDT
Created attachment 276940 [details]
an analysis of the makeup for the media controls.

Test case: http://ghbweb.com/ios_video_issue/

As a correct behavior, the media controls disappear at about 3 ~ 4 seconds after the play button is clicked. When a user starts a video and enter full screen, the controls (or the container anyway) remains in the DOM for about 3 ~ 4 before it disappears. When the user exists full screen mode, the controls return as operable invisible controls. Attached please see an analysis of the markup for the controls. It appears that "-webkit-media-controls-panel-background" and "-webkit-media-controls-panel" are missing the "show" class after the user exists full screen.
Comment 1 Radar WebKit Bug Importer 2016-04-21 11:50:42 PDT
<rdar://problem/25858658>
Comment 2 Aaron Chu 2016-05-09 01:24:06 PDT
Created attachment 278396 [details]
Patch
Comment 3 Aaron Chu 2016-05-09 01:27:14 PDT
Comment on attachment 278396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278396&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:-527
> -            this.showShowControlsButton(false);

moving this outside because it it not tied to the if-clause just as the base Controller.
Comment 4 chris fleizach 2016-05-09 01:33:38 PDT
Comment on attachment 278396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278396&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).

can you add a comment regarding how this was fixed

> ChangeLog:9
> +        * ManualTests/ios/video-cotnrols-to-show-on-inline-mode-from-fullscreen-button.html: Added.

is there anyway to make this an automated test

cotnrols spelled wrong

> ManualTests/ios/video-cotnrols-to-show-on-inline-mode-from-fullscreen-button.html:8
> +<p>This test can be used to verify that after exiting Full Screen mode using the "Full Screen" button, the inline video controls is shown and the "showControlButton" is hidden.</p>

... controls "are" shown...