Bug 156854 - [WK1] Add WebPlaybackSession support to WebKit
Summary: [WK1] Add WebPlaybackSession support to WebKit
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-21 10:58 PDT by Jer Noble
Modified: 2016-04-22 16:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.20 KB, patch)
2016-04-21 11:01 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (8.24 KB, patch)
2016-04-21 11:05 PDT, Jer Noble 		bdakin: review+
Details | Formatted Diff | Diff
Patch for landing (8.56 KB, patch)
2016-04-21 15:38 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-04-21 10:58:09 PDT 
[WK1] Add WebPlaybackSession support to WebKit
Comment 1 Jer Noble 2016-04-21 11:01:37 PDT 
Created attachment 276936 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-21 11:02:29 PDT 
Attachment 276936 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:8575:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2016-04-21 11:05:39 PDT 
Created attachment 276937 [details]
Patch
Comment 4 WebKit Commit Bot 2016-04-21 11:07:42 PDT 
Attachment 276937 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:8576:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Beth Dakin 2016-04-21 14:06:28 PDT 
Comment on attachment 276937 [details]
Patch

r=me, but definitely take a look at those red bots
Comment 6 Jer Noble 2016-04-21 15:38:48 PDT 
Created attachment 276972 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-04-21 15:49:44 PDT 
Attachment 276972 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebView.mm:8557:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2016-04-21 16:55:44 PDT 
Comment on attachment 276972 [details]
Patch for landing

Clearing flags on attachment: 276972

Committed r199846: <http://trac.webkit.org/changeset/199846>
Comment 9 Jon Lee 2016-04-22 16:43:04 PDT 
rdar://problem/24866862