Bug 156847 – [GTK][EFL] Move non-glib/gtk platform implementations out of platform/gtk

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Claudio Saavedra]

[GTK] Move non-glib/gtk platform implementations out of platform/gtk

[Claudio Saavedra]

Created attachment 276916 [details]
Patch

[WebKit Commit Bot]

Attachment 276916 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/unix/LanguageUnix.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Comment on attachment 276916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276916&action=review

> Source/WebCore/PlatformGTK.cmake:187
> +
> +    platform/unix/LanguageUnix.cpp
> +    platform/unix/LoggingUnix.cpp

You should do the same for EFL, since the implementation is now the same, no?

> Source/WebCore/platform/unix/LanguageUnix.cpp:25
> +

Remove this empty line here.

> Source/WebCore/platform/unix/LanguageUnix.cpp:49
> +    Vector<String> userPreferredLanguages;
> +    userPreferredLanguages.append(platformLanguage());
> +    return userPreferredLanguages;

This could just be return { platformLanguage() }; I think

> Source/WebCore/platform/unix/LoggingUnix.cpp:46
> +    String logLevel = "NotYetImplemented,";
> +    logLevel.append(logEnv);
> +    return logLevel;

And this could probably be return String("NotYetImplemented,") + logEnv

[Claudio Saavedra]

Created attachment 276922 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 276922 [details]
Patch for landing

Clearing flags on attachment: 276922

Committed r199815: <http://trac.webkit.org/changeset/199815>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Martin Robinson]

*** Bug 116460 has been marked as a duplicate of this bug. ***