Bug 156835 – [GTK] WebKitWebView should claim the contents size as its natural size

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

And keep claiming 0 as its minimum size since it's scrollable.

[Carlos Garcia Campos]

Created attachment 276902 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Zan Dobersek]

Comment on attachment 276902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276902&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1536
> +    if (priv->contentsSize == contentsSize)
> +        return;
> +    priv->contentsSize = contentsSize;

The early check-and-return doesn't help much IMO, since the assignment is the only change of state here, and there's no work or event propagated further if the same size is assigned.

[Carlos Garcia Campos]

(In reply to comment #3)
> Comment on attachment 276902 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276902&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1536
> > +    if (priv->contentsSize == contentsSize)
> > +        return;
> > +    priv->contentsSize = contentsSize;
> 
> The early check-and-return doesn't help much IMO, since the assignment is
> the only change of state here, and there's no work or event propagated
> further if the same size is assigned.

Yes, that's the case of this patch, but this is a actually a split of two patches. The other one adds new API to tell the web view to fit its size to the contents, so here I schedule a resize, but only when the contents size have actually changed.

[Carlos Garcia Campos]

Committed r199811: <http://trac.webkit.org/changeset/199811>