Bug 156833 - Build fail because of quotes.
Summary: Build fail because of quotes.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: PC Linux
: P2 Minor
Assignee: Konstantin Tokarev
Depends on:
Reported: 2016-04-20 22:00 PDT by Ryan Rafe Lee
Modified: 2017-02-16 09:12 PST (History)
5 users (show)

See Also:

patch (1.53 KB, patch)
2016-04-20 22:01 PDT, Ryan Rafe Lee
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2016-04-26 00:24 PDT, Ryan Rafe Lee
no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2017-02-16 04:28 PST, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Rafe Lee 2016-04-20 22:00:26 PDT
Build fails when upstream version string has some special letter. Because cmake automatically insert quotes when build. At Source/WebCore/CMakeList.txt, there's code setting PYTHONPATH variable.
When version has some special letter like '2.10.4+dev12~1.gbp7c2f8b' builds fail with error '/bin/sh: 1: PYTHONPATH=/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/Source/JavaScriptCore/inspector/scripts: not found'. Because command will be 'cd "/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/obj-i586-linux-gnu/Source/WebCore" && "PYTHONPATH=/tmp/buildd/webkit2gtk-2.10.4+dev12~1.gbp7c2f8b/Source/JavaScriptCore/inspector/scripts" /usr/bin/python2.7 ...'

ps. I changed format 3.0(quilt) to 3.0(native). Because I don't need quilt.
Comment 1 Ryan Rafe Lee 2016-04-20 22:01:18 PDT
Created attachment 276899 [details]
Comment 2 Alex Christensen 2016-04-25 11:09:16 PDT
The env command doesn't exist on Windows.
Comment 3 Ryan Rafe Lee 2016-04-26 00:24:22 PDT
Created attachment 277347 [details]

Use -E for platform independence. But '-E env' depends on cmake>=3.1.
Comment 4 Alex Christensen 2016-04-26 10:25:43 PDT
Comment on attachment 277347 [details]

We currently support CMake 2.8.12, and I don't think this alone is reason enough to bump the minimum version that high.
Comment 5 Konstantin Tokarev 2017-02-16 04:28:14 PST
Created attachment 301743 [details]
Comment 6 WebKit Commit Bot 2017-02-16 09:12:46 PST
Comment on attachment 301743 [details]

Clearing flags on attachment: 301743

Committed r212435: <http://trac.webkit.org/changeset/212435>
Comment 7 WebKit Commit Bot 2017-02-16 09:12:50 PST
All reviewed patches have been landed.  Closing bug.