Bug 156830 - DFG del_by_id support forgets to set()
Summary: DFG del_by_id support forgets to set()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-20 19:12 PDT by Filip Pizlo
Modified: 2016-04-20 19:35 PDT (History)
5 users (show)

See Also:

Attachments
the patch (2.66 KB, patch)
2016-04-20 19:17 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (1.99 KB, patch)
2016-04-20 19:20 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-20 19:12:36 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-04-20 19:17:37 PDT 
Created attachment 276885 [details]
the patch
Comment 2 WebKit Commit Bot 2016-04-20 19:19:11 PDT 
Attachment 276885 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4244:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-04-20 19:20:06 PDT 
(In reply to comment #2)
> Attachment 276885 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:4244:  One line
> control clauses should not use braces.  [whitespace/braces] [4]
> Total errors found: 1 in 3 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Oops, I'll remove that.
Comment 4 Filip Pizlo 2016-04-20 19:20:26 PDT 
Created attachment 276886 [details]
the patch
Comment 5 Filip Pizlo 2016-04-20 19:35:30 PDT 
Landed in http://trac.webkit.org/changeset/199801