Bug 156819 - AX: stringForTextMarkerRange returning empty string for document range
Summary: AX: stringForTextMarkerRange returning empty string for document range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-20 16:36 PDT by Nan Wang
Modified: 2016-04-21 01:41 PDT (History)
11 users (show)

See Also:

Attachments
Initial patch (5.43 KB, patch)
2016-04-20 17:15 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
patch (5.40 KB, patch)
2016-04-20 17:30 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-04-20 16:36:16 PDT 
Text markers created from visible positions might have PositionIsAfterAnchor anchor type, so CharacterOffset will be anchored to a different node.

<rdar://problem/25793161>
Comment 1 Radar WebKit Bug Importer 2016-04-20 16:36:40 PDT 
<rdar://problem/25842260>
Comment 2 Nan Wang 2016-04-20 17:15:11 PDT 
Created attachment 276872 [details]
Initial patch
Comment 3 chris fleizach 2016-04-20 17:22:10 PDT 
Comment on attachment 276872 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276872&action=review

> Source/WebCore/ChangeLog:9
> +        or PositionIsAfterChildren anchor type. So that the character offset corresponds to the anchored

this "nchor type. So that t" should be

"nchor type, so that t

> Source/WebCore/accessibility/AXObjectCache.cpp:1974
> +    // convert to character offset

this line seems superfluous

> Source/WebCore/accessibility/AXObjectCache.cpp:1975
> +    // If the visible position has anchor type referring to node other than the anchored node, we should 

has "an" anchor type
referring to "a" node
Comment 4 Nan Wang 2016-04-20 17:30:35 PDT 
Created attachment 276875 [details]
patch

review comments
Comment 5 WebKit Commit Bot 2016-04-21 01:40:56 PDT 
Comment on attachment 276875 [details]
patch

Clearing flags on attachment: 276875

Committed r199809: <http://trac.webkit.org/changeset/199809>
Comment 6 WebKit Commit Bot 2016-04-21 01:41:00 PDT 
All reviewed patches have been landed.  Closing bug.