Bug 156816 - Enable heap separation on X86_64
Summary: Enable heap separation on X86_64
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-20 15:21 PDT by Oliver Hunt
Modified: 2016-04-20 16:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.99 KB, patch)
2016-04-20 15:25 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (8.07 KB, patch)
2016-04-20 16:18 PDT, Oliver Hunt 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2016-04-20 15:21:57 PDT 
Enable heap separation on X86_64
Comment 1 Oliver Hunt 2016-04-20 15:25:39 PDT 
Created attachment 276858 [details]
Patch
Comment 2 Mark Lam 2016-04-20 15:41:30 PDT 
Comment on attachment 276858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276858&action=review

r=me with comments.

> Source/JavaScriptCore/assembler/X86Assembler.h:2776
> +        performJITMemcpy(ptr, buffer, 1 + sizeof(int32_t));

As an idiom, can we use "sizeof(buffer)" instead of "1 + sizeof(int32_t)"?  I would think it'd be less error prone to cut and paste errors this way.  Ditto for all the sizes passed to performJITMemcpy below where appropriate.
Comment 3 Oliver Hunt 2016-04-20 16:12:52 PDT 
I thought perf numbers were ok, but i think i ran the wrong builds, and am now getting too much variance. Also need to fix efl+ios sim
Comment 4 Oliver Hunt 2016-04-20 16:18:00 PDT 
Created attachment 276863 [details]
Patch
Comment 5 Mark Lam 2016-04-20 16:21:06 PDT 
Comment on attachment 276863 [details]
Patch

r=me if the bots are happy.