Bug 156813 - showCandidates() should take a range and the string should be the whole paragraph
Summary: showCandidates() should take a range and the string should be the whole parag...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-20 14:58 PDT by Beth Dakin
Modified: 2016-04-21 12:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.06 KB, patch)
2016-04-20 15:46 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (11.10 KB, patch)
2016-04-20 16:04 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-04-20 14:58:56 PDT 
showCandidates() should take a range and the string should be the whole paragraph
Comment 1 Beth Dakin 2016-04-20 15:46:55 PDT 
Created attachment 276860 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-20 15:49:13 PDT 
Attachment 276860 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2164:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1161:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1192:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2016-04-20 16:04:43 PDT 
Created attachment 276861 [details]
Patch
Comment 4 WebKit Commit Bot 2016-04-20 16:05:58 PDT 
Attachment 276861 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:2164:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1161:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1192:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Beth Dakin 2016-04-21 12:39:12 PDT 
Thanks Tim! http://trac.webkit.org/changeset/199828