Bug 156802 - Unindent an unnecessary block in stringProtoFuncSplitFast().
Summary: Unindent an unnecessary block in stringProtoFuncSplitFast().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-20 11:48 PDT by Mark Lam
Modified: 2016-04-22 11:36 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch. (8.95 KB, patch)
2016-04-20 11:55 PDT, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-04-20 11:48:53 PDT 
In webkit.org/b/156013, I refactored stringProtoFunc into stringProtoFuncSplit.  In that patch, I left an unnecessary block of code in its original block (with FIXMEs) to keep the diff for that patch minimal.  Now that the patch for webkit.org/b/156013 has landed, I will unindent that block and remove the FIXMEs.
Comment 1 Mark Lam 2016-04-20 11:50:35 PDT 
(In reply to comment #0)
> In webkit.org/b/156013, I refactored stringProtoFunc into
> stringProtoFuncSplit.  In that patch, I left an unnecessary block of code in
> its original block (with FIXMEs) to keep the diff for that patch minimal. 
> Now that the patch for webkit.org/b/156013 has landed, I will unindent that
> block and remove the FIXMEs.

typo: /stringProtoFunc/stringProtoFuncSplit/ and /stringProtoFuncSplit/stringProtoFuncSplitFast/.
Comment 2 Mark Lam 2016-04-20 11:55:41 PDT 
Created attachment 276838 [details]
proposed patch.
Comment 3 Mark Lam 2016-04-20 12:11:22 PDT 
Landed in r199780: <http://trac.webkit.org/r199780>.
Comment 4 Darin Adler 2016-04-22 11:36:09 PDT 
Comment on attachment 276838 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=276838&action=review

> Source/JavaScriptCore/runtime/StringPrototype.cpp:1191
> +    String separator = separatorValue.toString(exec)->value(exec);

Seems we should always use toWTFString instead of writing it out like this.