Bug 156801 – Anchor element 'ping' property should only apply to http/https destinations

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The HTML5 specification <https://developers.whatwg.org/links.html#ping> indicates: "The ping attribute, if present, gives the URLs of the resources that are interested in being notified if the user follows the hyperlink. The value must be a set of space-separated tokens, each of which must be a valid non-empty URL."

Although the specification indicates that it must be a "valid non-empty URL", it doesn't really make sense to support anything besides http/https destinations.

We should tighten up WebKit to ignore other protocols.

[Radar WebKit Bug Importer]

<rdar://problem/25834419>

[Brent Fulgham]

Created attachment 276870 [details]
Patch

[Brent Fulgham]

Created attachment 276938 [details]
Patch

[Chris Dumez]

Comment on attachment 276938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276938&action=review

> Source/WebCore/ChangeLog:14
> +        Tested by http/tests/navigation/ping-attribute tests.

Then why weren't this rebaselined?

[Brent Fulgham]

(In reply to comment #4)
> Comment on attachment 276938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276938&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        Tested by http/tests/navigation/ping-attribute tests.
> 
> Then why weren't this rebaselined?

It just confirms expected behavior still works. WebKitTestRunner doesn't have a way to test that local files have not been read.

[Chris Dumez]

Comment on attachment 276938 [details]
Patch

r=me

[Brent Fulgham]

Comment on attachment 276938 [details]
Patch

Clearing flags on attachment: 276938

Committed r199900: <http://trac.webkit.org/changeset/199900>

[Brent Fulgham]

All reviewed patches have been landed.  Closing bug.