Bug 156796 - Use Optional<size_t> for OrderIterator::m_orderIndex instead of int
Summary: Use Optional<size_t> for OrderIterator::m_orderIndex instead of int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-20 10:47 PDT by Chris Dumez
Modified: 2016-04-22 04:29 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2016-04-20 10:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-20 10:47:32 PDT 
Use Optional<size_t> for OrderIterator::m_orderIndex instead of int (with invalid value of -1). m_orderIndex a vector index and therefore is in the range of an unsigned (type used internally by Vector, even though the index is exposed as size_t). Therefore, assigning it to an int is unsafe as it may overflow.

This may fix <rdar://problem/23410338> which is a top crasher.
Comment 1 Chris Dumez 2016-04-20 10:57:13 PDT 
Created attachment 276832 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-20 14:07:19 PDT 
Comment on attachment 276832 [details]
Patch

Clearing flags on attachment: 276832

Committed r199785: <http://trac.webkit.org/changeset/199785>
Comment 3 WebKit Commit Bot 2016-04-20 14:07:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 David Kilzer (:ddkilzer) 2016-04-22 04:29:47 PDT 
<rdar://problem/23410338>