Bug 156787 – [GTK] Move GTK+-independent platform code to platform/glib

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Claudio Saavedra]

[GTK] Move GTK+-independent platform code to platform/glib

[Claudio Saavedra]

Created attachment 276813 [details]
Patch

[WebKit Commit Bot]

Attachment 276813 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/glib/SharedBufferGlib.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/glib/LanguageGlib.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Comment on attachment 276813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276813&action=review

> Source/WebCore/platform/glib/ErrorsGlib.h:21
> +#define ErrorsGlib_h

I'm not sure about this particular rename. This is not the glib implementation of anything, but the error messages used by the GTK port. In this case the Gtk in the name didn't refer to the GTk library, but the GTK port. I know it's confusing, but I think ErrorsGlib is more confusing.

> Source/WebCore/platform/glib/LanguageGlib.cpp:57
> +Vector<String> platformUserPreferredLanguages()

Something similar applies here. This is the implementation for the GTK+ port, nothing depends on GLib here.

> Source/WebCore/platform/glib/LoggingGlib.cpp:33
> +String logLevelString()

Ditto.

[Claudio Saavedra]

Created attachment 276816 [details]
Patch

[WebKit Commit Bot]

Attachment 276816 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/glib/SharedBufferGlib.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 276816 [details]
Patch

Clearing flags on attachment: 276816

Committed r199772: <http://trac.webkit.org/changeset/199772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.