Bug 156787 - [GTK] Move GTK+-independent platform code to platform/glib
Summary: [GTK] Move GTK+-independent platform code to platform/glib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-20 01:47 PDT by Claudio Saavedra
Modified: 2016-04-20 08:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (81.29 KB, patch)
2016-04-20 01:58 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Patch (49.40 KB, patch)
2016-04-20 04:34 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2016-04-20 01:47:05 PDT 
[GTK] Move GTK+-independent platform code to platform/glib
Comment 1 Claudio Saavedra 2016-04-20 01:58:42 PDT 
Created attachment 276813 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-20 01:59:42 PDT 
Attachment 276813 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/glib/SharedBufferGlib.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/glib/LanguageGlib.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2016-04-20 02:21:51 PDT 
Comment on attachment 276813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276813&action=review

> Source/WebCore/platform/glib/ErrorsGlib.h:21
> +#define ErrorsGlib_h

I'm not sure about this particular rename. This is not the glib implementation of anything, but the error messages used by the GTK port. In this case the Gtk in the name didn't refer to the GTk library, but the GTK port. I know it's confusing, but I think ErrorsGlib is more confusing.

> Source/WebCore/platform/glib/LanguageGlib.cpp:57
> +Vector<String> platformUserPreferredLanguages()

Something similar applies here. This is the implementation for the GTK+ port, nothing depends on GLib here.

> Source/WebCore/platform/glib/LoggingGlib.cpp:33
> +String logLevelString()

Ditto.
Comment 4 Claudio Saavedra 2016-04-20 04:34:10 PDT 
Created attachment 276816 [details]
Patch
Comment 5 WebKit Commit Bot 2016-04-20 04:35:00 PDT 
Attachment 276816 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/glib/SharedBufferGlib.cpp:25:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2016-04-20 08:02:49 PDT 
Comment on attachment 276816 [details]
Patch

Clearing flags on attachment: 276816

Committed r199772: <http://trac.webkit.org/changeset/199772>
Comment 7 WebKit Commit Bot 2016-04-20 08:02:54 PDT 
All reviewed patches have been landed.  Closing bug.