Bug 156781 – Drop [UsePointersEvenForNonNullableObjectArguments] from several Canvas interfaces

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Drop [UsePointersEvenForNonNullableObjectArguments] from several Canvas interfaces

[Chris Dumez]

Created attachment 276802 [details]
Patch

[Build Bot]

Comment on attachment 276802 [details]
Patch

Attachment 276802 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1189227

New failing tests:
canvas/philip/tests/2d.drawImage.null.html

[Build Bot]

Created attachment 276803 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276802 [details]
Patch

Attachment 276802 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1189238

New failing tests:
canvas/philip/tests/2d.drawImage.null.html

[Build Bot]

Created attachment 276804 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276802 [details]
Patch

Attachment 276802 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1189249

New failing tests:
canvas/philip/tests/2d.drawImage.null.html

[Build Bot]

Created attachment 276806 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276802 [details]
Patch

Attachment 276802 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1189369

New failing tests:
canvas/philip/tests/2d.drawImage.null.html

[Build Bot]

Created attachment 276807 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 276827 [details]
Patch

[Darin Adler]

Comment on attachment 276827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276827&action=review

Looks like this patch has more cases of null raising a different exception now than it was before. Would be nice to cover those in some existing regression test.

> Source/WebCore/html/canvas/WebGLDebugShaders.idl:31
> +    [StrictTypeChecking] DOMString? getTranslatedShaderSource(WebGLShader? shader);

No FIXME? Why is the shader nullable?

[Chris Dumez]

Comment on attachment 276827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276827&action=review

>> Source/WebCore/html/canvas/WebGLDebugShaders.idl:31
>> +    [StrictTypeChecking] DOMString? getTranslatedShaderSource(WebGLShader? shader);
> 
> No FIXME? Why is the shader nullable?

I did not find the corresponding spec but I'll give it another try.

[Chris Dumez]

Comment on attachment 276827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276827&action=review

>>> Source/WebCore/html/canvas/WebGLDebugShaders.idl:31
>>> +    [StrictTypeChecking] DOMString? getTranslatedShaderSource(WebGLShader? shader);
>> 
>> No FIXME? Why is the shader nullable?
> 
> I did not find the corresponding spec but I'll give it another try.

Ok, found it:
https://www.khronos.org/registry/webgl/extensions/WEBGL_debug_shaders/

Looks like it should not be nullable indeed. I'll add a FIXME

[Chris Dumez]

Created attachment 276831 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 276831 [details]
Patch

Clearing flags on attachment: 276831

Committed r199776: <http://trac.webkit.org/changeset/199776>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.