Bug 156767 - Replace $vm.printValue() with $vm.value().
Summary: Replace $vm.printValue() with $vm.value().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-19 16:11 PDT by Mark Lam
Modified: 2016-04-19 16:32 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch. (2.48 KB, patch)
2016-04-19 16:19 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-04-19 16:11:30 PDT
When debugging with $vm, this change allows us to do this:

    $vm.print("myObj = " + myObj + "\n");

... instead of having to do this:

    $vm.print("myObj = ");
    $vm.printValue(myObj);
    $vm.print("\n");
Comment 1 Mark Lam 2016-04-19 16:17:51 PDT
(In reply to comment #0)
> When debugging with $vm, this change allows us to do this:
> 
>     $vm.print("myObj = " + myObj + "\n");

I meant this change allows us to do this:

    $vm.print("myObj = " + $vm.value(myObj) + "\n");
Comment 2 Mark Lam 2016-04-19 16:19:50 PDT
Created attachment 276772 [details]
proposed patch.
Comment 3 Mark Lam 2016-04-19 16:32:11 PDT
Thanks for the review.  Landed in r199745: <http://trac.webkit.org/r199745>.