Bug 156755 - Update ANGLE
Summary: Update ANGLE
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 156789
  Show dependency treegraph
Reported: 2016-04-19 11:59 PDT by Alex Christensen
Modified: 2016-04-29 09:42 PDT (History)
3 users (show)

See Also:

patch (6.93 MB, patch)
2016-04-19 12:02 PDT, Alex Christensen
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-04-19 11:59:35 PDT
Let's update ANGLE.
Comment 1 Alex Christensen 2016-04-19 12:02:04 PDT
Created attachment 276741 [details]
Comment 2 Alex Christensen 2016-04-19 12:07:31 PDT
This regresses webgl/1.0.2/conformance/glsl/reserved/webgl_preprocessor_reserved.html but everything else passes.  I think looking into that after this lands is probably the best way to go.
Comment 3 Alex Christensen 2016-04-19 12:14:28 PDT
That test was removed in https://github.com/KhronosGroup/WebGL/pull/1230
I think I'll remove it, too.
Comment 4 Dean Jackson 2016-04-19 12:14:54 PDT
Looking at the patch offline.
Comment 5 Dean Jackson 2016-04-19 12:24:40 PDT
Comment on attachment 276741 [details]

I checked that Alex updated the .plist file we use for our Open Source contributions, and that he kept the legal note about how we're distributing the generated source.
Comment 6 Alex Christensen 2016-04-19 12:46:47 PDT
Comment 7 Antoine Quint 2016-04-20 07:42:03 PDT
This caused LayoutTests/compositing/webgl/webgl-reflection.html to regress on the iOS Simulator bot. See https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r199771%20(4996)/compositing/webgl/webgl-reflection-pretty-diff.html.
Comment 8 Jeremy Huddleston Sequoia 2016-04-29 09:42:07 PDT
This change also causes the gtk build to fail.  This can be seen by the red in the attachments field.  Why was this pushed given the known fallout?