Bug 156751 - JavaScriptCore garbage collection is missing an autorelease pool
Summary: JavaScriptCore garbage collection is missing an autorelease pool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-19 11:41 PDT by Geoffrey Garen
Modified: 2016-04-24 09:57 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2016-04-19 11:43 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2016-04-19 11:43 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2016-04-19 12:32 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (498.35 KB, application/zip)
2016-04-19 13:25 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.27 MB, application/zip)
2016-04-19 13:41 PDT, Build Bot 		no flags Details
Patch (3.85 KB, patch)
2016-04-20 19:25 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.84 KB, patch)
2016-04-20 19:56 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2016-04-20 19:58 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-04-19 11:41:42 PDT 
JavaScriptCore garbage collection is missing an autorelease pool
Comment 1 Geoffrey Garen 2016-04-19 11:43:03 PDT 
Created attachment 276735 [details]
Patch
Comment 2 Geoffrey Garen 2016-04-19 11:43:37 PDT 
Created attachment 276736 [details]
Patch
Comment 3 WebKit Commit Bot 2016-04-19 11:44:40 PDT 
Attachment 276736 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:64:  Declaration has space between type name and * in typedef void *NSAutoreleasePoolMark  [whitespace/declaration] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2016-04-19 12:32:59 PDT 
Created attachment 276745 [details]
Patch
Comment 5 Mark Lam 2016-04-19 12:34:48 PDT 
Comment on attachment 276745 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2016-04-19 12:35:02 PDT 
Attachment 276745 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:64:  Declaration has space between type name and * in typedef void *NSAutoreleasePoolMark  [whitespace/declaration] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Build Bot 2016-04-19 13:25:39 PDT 
Comment on attachment 276745 [details]
Patch

Attachment 276745 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1187264

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-04-19 13:25:42 PDT 
Created attachment 276750 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-04-19 13:41:02 PDT 
Comment on attachment 276745 [details]
Patch

Attachment 276745 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1187273

Number of test failures exceeded the failure limit.
Comment 10 Build Bot 2016-04-19 13:41:05 PDT 
Created attachment 276753 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Geoffrey Garen 2016-04-19 13:58:01 PDT 
Comment on attachment 276745 [details]
Patch

Crashes in release wk1 builds.
Comment 12 Geoffrey Garen 2016-04-20 19:25:12 PDT 
Created attachment 276887 [details]
Patch
Comment 13 Saam Barati 2016-04-20 19:33:53 PDT 
Comment on attachment 276887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276887&action=review

> Source/JavaScriptCore/heap/Heap.cpp:402
> +#if USE(FOUNDATION)

Shouldn't this still be inside the function?
Comment 14 Geoffrey Garen 2016-04-20 19:56:07 PDT 
Created attachment 276891 [details]
Patch
Comment 15 Geoffrey Garen 2016-04-20 19:58:31 PDT 
Created attachment 276893 [details]
Patch
Comment 16 Mark Lam 2016-04-20 20:30:42 PDT 
Comment on attachment 276893 [details]
Patch

r=me
Comment 17 Geoffrey Garen 2016-04-20 20:50:32 PDT 
Comment on attachment 276893 [details]
Patch

cq+ 🍀
Comment 18 WebKit Commit Bot 2016-04-20 21:39:59 PDT 
Comment on attachment 276893 [details]
Patch

Clearing flags on attachment: 276893

Committed r199803: <http://trac.webkit.org/changeset/199803>
Comment 19 WebKit Commit Bot 2016-04-20 21:40:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 20 Darin Adler 2016-04-24 09:57:14 PDT 
Comment on attachment 276893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276893&action=review

> Source/JavaScriptCore/heap/Heap.cpp:421
> +                void* context = objc_autoreleasePoolPush();

Gotta say, auto was made for situations like this, where we don’t care at all what the type of "context" is.