Bug 156751 – JavaScriptCore garbage collection is missing an autorelease pool

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

JavaScriptCore garbage collection is missing an autorelease pool

[Geoffrey Garen]

Created attachment 276735 [details]
Patch

[Geoffrey Garen]

Created attachment 276736 [details]
Patch

[WebKit Commit Bot]

Attachment 276736 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:64:  Declaration has space between type name and * in typedef void *NSAutoreleasePoolMark  [whitespace/declaration] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Created attachment 276745 [details]
Patch

[Mark Lam]

Comment on attachment 276745 [details]
Patch

r=me

[WebKit Commit Bot]

Attachment 276745 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:64:  Declaration has space between type name and * in typedef void *NSAutoreleasePoolMark  [whitespace/declaration] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 276745 [details]
Patch

Attachment 276745 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1187264

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 276750 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276745 [details]
Patch

Attachment 276745 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1187273

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 276753 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Geoffrey Garen]

Comment on attachment 276745 [details]
Patch

Crashes in release wk1 builds.

[Geoffrey Garen]

Created attachment 276887 [details]
Patch

[Saam Barati]

Comment on attachment 276887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276887&action=review

> Source/JavaScriptCore/heap/Heap.cpp:402
> +#if USE(FOUNDATION)

Shouldn't this still be inside the function?

[Geoffrey Garen]

Created attachment 276891 [details]
Patch

[Geoffrey Garen]

Created attachment 276893 [details]
Patch

[Mark Lam]

Comment on attachment 276893 [details]
Patch

r=me

[Geoffrey Garen]

Comment on attachment 276893 [details]
Patch

cq+ 🍀

[WebKit Commit Bot]

Comment on attachment 276893 [details]
Patch

Clearing flags on attachment: 276893

Committed r199803: <http://trac.webkit.org/changeset/199803>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 276893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276893&action=review

> Source/JavaScriptCore/heap/Heap.cpp:421
> +                void* context = objc_autoreleasePoolPush();

Gotta say, auto was made for situations like this, where we don’t care at all what the type of "context" is.