WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
156749
Paths returned by fileSystemRepresentation are not consistently checked for Null strings
https://bugs.webkit.org/show_bug.cgi?id=156749
Summary
Paths returned by fileSystemRepresentation are not consistently checked for N...
Brent Fulgham
Reported
2016-04-19 09:48:00 PDT
Our FileSystem::fileSystemRepresentation method returns CString() under various error conditions. In most cases, we check for a null return of this method before passing the result on to functions (primarily POSIX routines) that are specified as crashing (or undefined behavior) if given a NULL input. We need to be consistent about checking this return value.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-04-19 11:04:20 PDT
<
rdar://problem/25807632
>
Brent Fulgham
Comment 2
2016-04-19 11:58:38 PDT
I did a search for instances of 'fileSystemRepresentation', and found that all cases except for SandboxExtension::createHandle were safe. The various POSIX functions called with the result of this function handle null inputs properly.
Brent Fulgham
Comment 3
2016-04-19 14:22:37 PDT
No changes needed here. A fix for SandboxExtension::createHandle will be landed soon.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug