http://trac.webkit.org/changeset/199726 broke the build: WebKit tests crash on Windows 32 (Requested by msaboff on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Created attachment 276729 [details] ROLLOUT of r199726 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Comment on attachment 276729 [details] ROLLOUT of r199726 Clearing flags on attachment: 276729 Committed r199729: <http://trac.webkit.org/changeset/199729>
All reviewed patches have been landed. Closing bug.
I think the function passed as parameter in the FlsAlloc call needs to have the stdcall calling convention, and not the cdecl convention. FlsAlloc(reinterpret_cast<PFLS_CALLBACK_FUNCTION>(destructor));
(In reply to comment #4) > I think the function passed as parameter in the FlsAlloc call needs to have > the stdcall calling convention, and not the cdecl convention. > > FlsAlloc(reinterpret_cast<PFLS_CALLBACK_FUNCTION>(destructor)); Thanks for the pointer. Looks like that fixes Windows 32.