Bug 156742 - [Cairo] GraphicsContext::drawFocusRing methods are not consistent to each other
Summary: [Cairo] GraphicsContext::drawFocusRing methods are not consistent to each other
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Cairo, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2016-04-19 06:17 PDT by Carlos Garcia Campos
Modified: 2016-04-19 08:10 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.98 KB, patch)
2016-04-19 06:20 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Try to fix EFL build (4.00 KB, patch)
2016-04-19 06:48 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-04-19 06:17:47 PDT
We are rendering the focus ring differently depending on whether a path is used or a vector of rectangles. This is causing that some reftests fail because they assume we always render the focus ring the same way. For example fast/images/image-map-outline-in-positioned-container.html, when rendering the test GraphicsContext::drawFocusRing is called with a path, and when rendering the reference it's called with a vector of rectangles, producing different results.
Comment 1 Carlos Garcia Campos 2016-04-19 06:20:55 PDT
Created attachment 276719 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-04-19 06:48:43 PDT
Created attachment 276721 [details]
Try to fix EFL build
Comment 3 Carlos Garcia Campos 2016-04-19 08:10:29 PDT
Committed r199727: <http://trac.webkit.org/changeset/199727>