Bug 156735 – [EFL] Fix broken layout and perf tests since r199658

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Gyuyoung Kim]

If EFL port calls InitializeWebKit2() before platformInitialize(), layout and perf tests are broken on EFL port.

[Gyuyoung Kim]

Created attachment 276698 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 276698 [details]
Patch

Do you know why are the crashes happening? If we understand the problem, we can try to properly fix this instead of adding platform ifdefs. For example, we could split platformInitialize in pre/post methods, and then GTK+ would implement only the post and EFL could move what needs to be done before InitializeWebKit2 to the pre method. I'll roll the patch out while we figure out what's wrong a how to properly fix it.

[Gyuyoung Kim]

(In reply to comment #2)
> Comment on attachment 276698 [details]
> Patch
> 
> Do you know why are the crashes happening? If we understand the problem, we
> can try to properly fix this instead of adding platform ifdefs. For example,
> we could split platformInitialize in pre/post methods, and then GTK+ would
> implement only the post and EFL could move what needs to be done before
> InitializeWebKit2 to the pre method. I'll roll the patch out while we figure
> out what's wrong a how to properly fix it.

Thank you for reverting it. I don't know it yet. Let me try to check why EFL can't call it before platformInitialize when I free.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.