Bug 156735 - [EFL] Fix broken layout and perf tests since r199658
Summary: [EFL] Fix broken layout and perf tests since r199658
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 156622
Blocks:
  Show dependency tree / graph
 
Reported: 2016-04-18 23:04 PDT by Gyuyoung Kim
Modified: 2017-03-11 10:38 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2016-04-18 23:06 PDT, Gyuyoung Kim 		cgarcia: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-04-18 23:04:46 PDT 
If EFL port calls InitializeWebKit2() before platformInitialize(), layout and perf tests are broken on EFL port.
Comment 1 Gyuyoung Kim 2016-04-18 23:06:56 PDT 
Created attachment 276698 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-04-19 00:15:21 PDT 
Comment on attachment 276698 [details]
Patch

Do you know why are the crashes happening? If we understand the problem, we can try to properly fix this instead of adding platform ifdefs. For example, we could split platformInitialize in pre/post methods, and then GTK+ would implement only the post and EFL could move what needs to be done before InitializeWebKit2 to the pre method. I'll roll the patch out while we figure out what's wrong a how to properly fix it.
Comment 3 Gyuyoung Kim 2016-04-19 00:18:21 PDT 
(In reply to comment #2)
> Comment on attachment 276698 [details]
> Patch
> 
> Do you know why are the crashes happening? If we understand the problem, we
> can try to properly fix this instead of adding platform ifdefs. For example,
> we could split platformInitialize in pre/post methods, and then GTK+ would
> implement only the post and EFL could move what needs to be done before
> InitializeWebKit2 to the pre method. I'll roll the patch out while we figure
> out what's wrong a how to properly fix it.

Thank you for reverting it. I don't know it yet. Let me try to check why EFL can't call it before platformInitialize when I free.
Comment 4 Michael Catanzaro 2017-03-11 10:38:44 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.