Bug 156734 - bmalloc: Merge the large and xlarge allocators
Summary: bmalloc: Merge the large and xlarge allocators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-18 22:57 PDT by Geoffrey Garen
Modified: 2016-04-19 16:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (121.28 KB, patch)
2016-04-18 23:04 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (121.32 KB, patch)
2016-04-19 00:16 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (121.36 KB, patch)
2016-04-19 00:33 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (121.88 KB, patch)
2016-04-19 00:38 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (121.89 KB, patch)
2016-04-19 00:42 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2016-04-18 22:57:05 PDT 
bmalloc: Merge the large and xlarge allocators
Comment 1 Geoffrey Garen 2016-04-18 23:04:51 PDT 
Created attachment 276697 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-18 23:07:12 PDT 
Attachment 276697 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Map.h:113:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2016-04-19 00:16:38 PDT 
Created attachment 276699 [details]
Patch
Comment 4 WebKit Commit Bot 2016-04-19 00:19:08 PDT 
Attachment 276699 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Map.h:113:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2016-04-19 00:33:23 PDT 
Created attachment 276701 [details]
Patch
Comment 6 WebKit Commit Bot 2016-04-19 00:36:11 PDT 
Attachment 276701 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Map.h:113:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Geoffrey Garen 2016-04-19 00:38:57 PDT 
Created attachment 276702 [details]
Patch
Comment 8 WebKit Commit Bot 2016-04-19 00:41:04 PDT 
Attachment 276702 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Map.h:113:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Geoffrey Garen 2016-04-19 00:42:25 PDT 
Created attachment 276703 [details]
Patch
Comment 10 WebKit Commit Bot 2016-04-19 00:43:45 PDT 
Attachment 276703 [details] did not pass style-queue:


ERROR: Source/bmalloc/bmalloc/Map.h:113:  Use 'WTFMove()' instead of 'std::move()'.  [runtime/wtf_move] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Andreas Kling 2016-04-19 13:23:52 PDT 
Comment on attachment 276703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276703&action=review

r=me

> Source/bmalloc/ChangeLog:81
> +        (bmalloc::ChunkHash::hash): Added a hash function. The best hash function
> +        is a unique and monotonically increasing integer, and that's exactly what
> +        we typically get from the high bits of a Chunk, since the OS allocates
> +        Chunks at unique and increasing addresses.

I learned something from this comment.
Comment 12 Geoffrey Garen 2016-04-19 15:48:33 PDT 
Comment on attachment 276703 [details]
Patch

cq+ 🍀
Comment 13 WebKit Commit Bot 2016-04-19 16:36:04 PDT 
Comment on attachment 276703 [details]
Patch

Clearing flags on attachment: 276703

Committed r199746: <http://trac.webkit.org/changeset/199746>
Comment 14 WebKit Commit Bot 2016-04-19 16:36:10 PDT 
All reviewed patches have been landed.  Closing bug.