Bug 156729 - REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations view are too large
Summary: REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations view are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-18 21:56 PDT by Joseph Pecoraro
Modified: 2016-04-19 05:34 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.02 KB, patch)
2016-04-18 21:59 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-18 21:56:45 PDT 
* SUMMARY
Percentages in Heap Allocations view are too large.

Number.prototype.percentageString changed to use Number.prototype.toLocaleString's "percent" style and required a callsite change. However not all callsites were updated.
Comment 1 Radar WebKit Bug Importer 2016-04-18 21:57:06 PDT 
<rdar://problem/25796002>
Comment 2 Joseph Pecoraro 2016-04-18 21:59:59 PDT 
Created attachment 276693 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-04-19 05:34:16 PDT 
Comment on attachment 276693 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 276693

Committed r199721: <http://trac.webkit.org/changeset/199721>
Comment 4 WebKit Commit Bot 2016-04-19 05:34:19 PDT 
All reviewed patches have been landed.  Closing bug.