Bug 156723 - Context menu items related to fullscreen should be specific to standard fullscreen
Summary: Context menu items related to fullscreen should be specific to standard fulls...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-18 17:13 PDT by Ada Chan
Modified: 2016-04-19 10:59 PDT (History)
0 users

See Also:


Attachments
Patch (4.46 KB, patch)
2016-04-18 17:23 PDT, Ada Chan
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-04-18 17:13:42 PDT
Context menu items related to fullscreen should be specific to standard fullscreen.

Right now the code uses HTMLMediaElement::isFullscreen() to check whether it should display "Enter Full Screen" or "Exit Full Screen", which could return true for other fullscreen modes. We should use a more specific check since the action of "Enter Full Screen" is going to standard full screen.

<rdar://problem/25452632>
Comment 1 Ada Chan 2016-04-18 17:23:11 PDT
Created attachment 276682 [details]
Patch
Comment 2 Ada Chan 2016-04-19 10:59:06 PDT
Committed:
http://trac.webkit.org/changeset/199733