Bug 156719 - Web Inspector: Debugger sidebar should include a warning message breakpoints are disabled
Summary: Web Inspector: Debugger sidebar should include a warning message breakpoints ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-18 14:56 PDT by Joseph Pecoraro
Modified: 2016-09-08 10:39 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (7.50 KB, patch)
2016-09-08 00:33 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[IMAGE] Breakpoints Disabled Warning (343.12 KB, image/png)
2016-09-08 00:33 PDT, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-18 14:56:32 PDT
* SUMMARY
Debugger sidebar should include a warning message breakpoints are disabled.

* NOTES
It should be easier to notice when breakpoints are disabled, and understand the consequences (breakpoints and debugger statements are disabled).
Comment 1 Radar WebKit Bug Importer 2016-04-18 14:57:26 PDT
<rdar://problem/25787932>
Comment 2 Joseph Pecoraro 2016-09-08 00:33:30 PDT
Created attachment 288253 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-09-08 00:33:55 PDT
Created attachment 288254 [details]
[IMAGE] Breakpoints Disabled Warning
Comment 4 Blaze Burg 2016-09-08 10:18:29 PDT
Comment on attachment 288253 [details]
[PATCH] Proposed Fix

r=me It might be cleaner to use a View class eventually but this is fine for now.
Comment 5 WebKit Commit Bot 2016-09-08 10:39:54 PDT
Comment on attachment 288253 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 288253

Committed r205651: <http://trac.webkit.org/changeset/205651>
Comment 6 WebKit Commit Bot 2016-09-08 10:39:58 PDT
All reviewed patches have been landed.  Closing bug.