Bug 156714 - Swipe view gesture should be reversed in right-to-left contexts
Summary: Swipe view gesture should be reversed in right-to-left contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-18 13:34 PDT by Tim Horton
Modified: 2016-04-18 16:00 PDT (History)
11 users (show)

See Also:

Attachments
Patch (15.70 KB, patch)
2016-04-18 13:34 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (18.13 KB, patch)
2016-04-18 14:35 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (18.70 KB, patch)
2016-04-18 14:58 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-04-18 13:34:35 PDT 
Swipe view gesture should be reversed in right-to-left contexts
Comment 1 Tim Horton 2016-04-18 13:34:55 PDT 
Created attachment 276662 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-18 13:36:32 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2016-04-18 13:36:43 PDT 
Attachment 276662 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1107:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2016-04-18 14:35:36 PDT 
Created attachment 276672 [details]
Patch
Comment 5 WebKit Commit Bot 2016-04-18 14:38:25 PDT 
Attachment 276672 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/UserInterfaceLayoutDirection.h:31:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tim Horton 2016-04-18 14:58:20 PDT 
Created attachment 276673 [details]
Patch
Comment 7 Tim Horton 2016-04-18 15:03:26 PDT 
<rdar://problem/24249978>
Comment 8 WebKit Commit Bot 2016-04-18 16:00:14 PDT 
Comment on attachment 276673 [details]
Patch

Clearing flags on attachment: 276673

Committed r199695: <http://trac.webkit.org/changeset/199695>
Comment 9 WebKit Commit Bot 2016-04-18 16:00:19 PDT 
All reviewed patches have been landed.  Closing bug.