Bug 156712 - ToThis should have a fast path based on type info flags
Summary: ToThis should have a fast path based on type info flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-18 12:51 PDT by Filip Pizlo
Modified: 2016-04-18 13:33 PDT (History)
5 users (show)

See Also:

Attachments
the patch (10.02 KB, patch)
2016-04-18 12:53 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-04-18 12:51:45 PDT 
Patch forthcoming
Comment 1 Filip Pizlo 2016-04-18 12:53:46 PDT 
Created attachment 276659 [details]
the patch
Comment 2 WebKit Commit Bot 2016-04-18 12:55:56 PDT 
Attachment 276659 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:3846:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:3901:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-04-18 12:58:28 PDT 
Running 32-bit debug tests now...
Comment 4 Geoffrey Garen 2016-04-18 12:59:14 PDT 
Comment on attachment 276659 [details]
the patch

r=me
Comment 5 Filip Pizlo 2016-04-18 13:26:16 PDT 
I have a trivial fix for 32-bit.
Comment 6 Filip Pizlo 2016-04-18 13:33:54 PDT 
Landed in http://trac.webkit.org/changeset/199686