RESOLVED FIXED 156707
Web Inspector: Creating the CSSStyleDetailsSidebarPanel takes about 50ms (20%) of main load 
https://bugs.webkit.org/show_bug.cgi?id=156707
Summary Web Inspector: Creating the CSSStyleDetailsSidebarPanel takes about 50ms (20%...
Timothy Hatcher
Reported 2016-04-18 10:12:23 PDT
Created attachment 276644 [details] Screenshot of a profile We should be able to lazy land most of CSSStyleDetailsSidebarPanel and the sub-panels to speed this up.
Attachments
Screenshot of a profile (278.17 KB, image/png)
2016-04-18 10:12 PDT, Timothy Hatcher 		no flags
Details
[Profile] First optimization pass (371.22 KB, image/png)
2016-04-23 16:32 PDT, Matt Baker 		no flags
Details
[Profile] 2nd optimization pass (347.24 KB, image/png)
2016-04-23 21:49 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (34.47 KB, patch)
2016-05-20 15:47 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (46.48 KB, patch)
2016-05-20 17:06 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (46.86 KB, patch)
2016-05-20 17:57 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-18 10:12:54 PDT
<rdar://problem/25780404>
Matt Baker
Comment 2 2016-04-23 16:32:55 PDT
Created attachment 277171 [details] [Profile] First optimization pass Lazily creating the VisualStylesSidebar UI when the panel is shown reduces CSSStyleDetailsSidebarPanel load time from 50ms to ~14ms. Will try lazy loading other panels next.
Matt Baker
Comment 3 2016-04-23 21:49:55 PDT
Created attachment 277180 [details] [Profile] 2nd optimization pass Although load times necessarily vary, lazy loading all sidebars sped up the loading of the frontend by over 40%! CSSStyleDetailsSidebarPanel now takes > 2ms at startup if hidden by default.
Matt Baker
Comment 4 2016-04-23 21:51:05 PDT
(In reply to comment #3) > Created attachment 277180 [details] > [Profile] 2nd optimization pass > > CSSStyleDetailsSidebarPanel now takes > 2ms at startup if hidden by default. < 2ms
Matt Baker
Comment 5 2016-05-20 15:47:48 PDT
Created attachment 279508 [details] [Patch] Proposed Fix
Matt Baker
Comment 6 2016-05-20 17:06:31 PDT
Created attachment 279518 [details] [Patch] Proposed Fix
Matt Baker
Comment 7 2016-05-20 17:27:40 PDT
Comment on attachment 279518 [details] [Patch] Proposed Fix Looks like this breaks DataGrid column layout
Matt Baker
Comment 8 2016-05-20 17:57:40 PDT
Created attachment 279527 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 9 2016-05-21 12:20:36 PDT
Comment on attachment 279527 [details] [Patch] Proposed Fix Clearing flags on attachment: 279527 Committed r201245: <http://trac.webkit.org/changeset/201245>
WebKit Commit Bot
Comment 10 2016-05-21 12:20:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.