Bug 156706 - Remove all use of Deprecated::ScriptValue in generated bindings
Summary: Remove all use of Deprecated::ScriptValue in generated bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-18 09:30 PDT by Darin Adler
Modified: 2019-01-15 17:10 PST (History)
10 users (show)

See Also:

Attachments
Patch (21.04 KB, patch)
2016-04-18 09:38 PDT, Darin Adler 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-04-18 09:30:45 PDT 
Remove all use of Deprecated::ScriptValue in generated bindings
Comment 1 Darin Adler 2016-04-18 09:38:11 PDT 
Created attachment 276643 [details]
Patch
Comment 2 Darin Adler 2016-04-18 09:39:49 PDT 
Brady, I think you’ll like this patch even more than the last one. This removes Deprecated::ScriptValue use entirely from the JavaScript bindings generator. And it gets us really close to removing the need for ImplementationReturnType entirely.
Comment 3 Brady Eidson 2016-04-18 10:05:09 PDT 
I have not opened the patch yet, but can't believe it's as small as it is.
Comment 4 Brady Eidson 2016-04-18 10:12:59 PDT 
Comment on attachment 276643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276643&action=review

> Source/WebCore/Modules/indexeddb/IDBKeyRange.h:70
> +    // FIXME: Eventually shoudl probably change all callers to call the ExecState version.

shoudl
Comment 5 Brady Eidson 2016-04-18 10:13:45 PDT 
mac-wk2 ews - while not done yet - suggests at least 1 test failure.
Comment 6 Darin Adler 2016-04-18 19:58:28 PDT 
Committed r199704: <http://trac.webkit.org/changeset/199704>
Comment 8 Darin Adler 2016-04-18 22:05:38 PDT 
Fixed that.

Committed r199706: <http://trac.webkit.org/changeset/199706>