Bug 156704 - Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout on busy sites
Summary: Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-18 08:46 PDT by Timothy Hatcher
Modified: 2016-04-18 10:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.93 KB, patch)
2016-04-18 08:51 PDT, Timothy Hatcher 		bburg: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-04-18 08:46:49 PDT 
The NavigationSidebarPanel code for showing and hiding the bottom border when there is overflow is pretty aggressive. We can tone it down and still get the right effect.
Comment 1 Radar WebKit Bug Importer 2016-04-18 08:47:31 PDT 
<rdar://problem/25778744>
Comment 2 Timothy Hatcher 2016-04-18 08:51:46 PDT 
Created attachment 276642 [details]
Patch
Comment 3 BJ Burg 2016-04-18 09:33:27 PDT 
Comment on attachment 276642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276642&action=review

r=me

> Source/WebInspectorUI/ChangeLog:13
> +        Use _updateContentOverflowShadowVisibilitySoon is more places so the style recalc

Nit: 'in more places'
Comment 4 Timothy Hatcher 2016-04-18 10:29:46 PDT 
Comment on attachment 276642 [details]
Patch

https://trac.webkit.org/changeset/199678