Bug 156672 – Element should be const in StyleResolver

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Resolving element style shouldn't mutate it.

[Antti Koivisto]

Created attachment 276580 [details]
patch

[Antti Koivisto]

Created attachment 276581 [details]
patch

[Antti Koivisto]

Created attachment 276582 [details]
patch

[Antti Koivisto]

Created attachment 276583 [details]
patch

[Antti Koivisto]

Created attachment 276584 [details]
patch

[Build Bot]

Comment on attachment 276584 [details]
patch

Attachment 276584 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1173081

New failing tests:
imported/blink/fast/css3-text/css3-text-decoration/stable/first-letter-text-decoration.html
fast/text/text-underline-first-line-decoration.html
fast/text/text-underline-vertical-first-line-decoration.html
fast/css/text-decorations-on-first-line-and-containing-block.html

[Build Bot]

Created attachment 276585 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276584 [details]
patch

Attachment 276584 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1173080

New failing tests:
imported/blink/fast/css3-text/css3-text-decoration/stable/first-letter-text-decoration.html
fast/text/text-underline-first-line-decoration.html
fast/text/text-underline-vertical-first-line-decoration.html
fast/css/text-decorations-on-first-line-and-containing-block.html

[Build Bot]

Created attachment 276586 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 276584 [details]
patch

Attachment 276584 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1173107

New failing tests:
imported/blink/fast/css3-text/css3-text-decoration/stable/first-letter-text-decoration.html
fast/text/text-underline-first-line-decoration.html
fast/text/text-underline-vertical-first-line-decoration.html
fast/css/text-decorations-on-first-line-and-containing-block.html

[Build Bot]

Created attachment 276587 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 276588 [details]
patch

[Darin Adler]

Comment on attachment 276588 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276588&action=review

I assume the idea here is to use const to sort of mean "DOM mutation forbidden".

> Source/WebCore/ChangeLog:10
> +        This patch just does Element* -> const Element*, all the groundwork has beend done already.

Typo: beend

> Source/WebCore/css/StyleResolver.cpp:761
> +void StyleResolver::adjustRenderStyle(RenderStyle& style, const RenderStyle& parentStyle, const Element *element)

Space should be after the *, not before it.

> Source/WebCore/rendering/RenderThemeIOS.mm:628
>      else if (element->hasTagName(HTMLNames::inputTag))
> -        adjustInputElementButtonStyle(style, static_cast<HTMLInputElement&>(*element));
> +        adjustInputElementButtonStyle(style, downcast<HTMLInputElement>(*element));

Should also use is<HTMLInputElement> instead of hasTagName(HTMLNames::inputTag).

[Antti Koivisto]

> I assume the idea here is to use const to sort of mean "DOM mutation
> forbidden".

Yes, minus the "sort of". Also compile-time check that that is indeed true.

[Antti Koivisto]

http://trac.webkit.org/changeset/199640

[Simon Fraser (smfr)]

This caused bug 157199