We make a large table that is causing major rendering hangs. We should only need to make a table for the visible portion of the table (plus some padding rows to reduce scrolling flashes).
<rdar://problem/25765256>
Created attachment 276684 [details] Patch
Comment on attachment 276684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276684&action=review > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:40 > + this.rows = []; This could be _rows, since it's an implementation detail only accessed by DataGrid and DataGridNode. > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:547 > + var dividerElement = headerCellElement.createChild("div", "divider"); let > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:549 > + var collapseDiv = headerCellElement.createChild("div", "collapser-button"); let
Created attachment 276766 [details] Patch
Comment on attachment 276766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276766&action=review r=me > Source/WebInspectorUI/ChangeLog:12 > + Call uplateLayoutIfNeeded since we don't use views here. Typo: "uplate" in many places in this ChangeLog. > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:252 > + set inline(x) These setters should bail if the value didn't change. > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1089 > + // A sortable data grid might not be in added to a view, so it needs its layout updated here. Grammar: "might not be in added"
Comment on attachment 276766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276766&action=review > Source/WebInspectorUI/ChangeLog:33 > + when the virtural table starts at an odd row. Typo: "virtural"
Comment on attachment 276766 [details] Patch https://trac.webkit.org/changeset/199747