Bug 156661 - [GTK] Possible off-by-one in hyphenation code
Summary: [GTK] Possible off-by-one in hyphenation code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
: 143924 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-16 08:50 PDT by Michael Catanzaro
Modified: 2016-04-18 19:33 PDT (History)
4 users (show)

See Also:

Attachments
Patch (427.33 KB, patch)
2016-04-18 14:13 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-04-16 08:50:37 PDT 
I've noticed an interesting difference in how we hyphenate words compared to Firefox.

E.g. some examples from https://blogs.gnome.org/mclasen/2016/04/15/my-first-xdg-app/

Firefox: environ-ment
WebKit: enviro-nment

Firefox: hav-ing
WebKit: ha-ving

Firefox: run-time
WebKit: ru-ntime

Firefox: com-mand
WebKit: co-mmand

Firefox's hyphenations are clearly superior. This looks pretty suspicious; could we have an off-by-one in our code?
Comment 1 Martin Robinson 2016-04-18 10:46:20 PDT 
Michael, I think you are correct. I'm working on a fix for this now.
Comment 2 Martin Robinson 2016-04-18 11:01:49 PDT 
*** Bug 143924 has been marked as a duplicate of this bug. ***
Comment 3 Martin Robinson 2016-04-18 14:13:30 PDT 
Created attachment 276666 [details]
Patch
Comment 4 WebKit Commit Bot 2016-04-18 19:33:10 PDT 
Comment on attachment 276666 [details]
Patch

Clearing flags on attachment: 276666

Committed r199703: <http://trac.webkit.org/changeset/199703>
Comment 5 WebKit Commit Bot 2016-04-18 19:33:15 PDT 
All reviewed patches have been landed.  Closing bug.