Bug 156658 – Add support for NSSharingService to MiniBrowser, for no great reasons

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Add support for NSSharingService to MiniBrowser, for no great reasons

[Sam Weinig]

Created attachment 276546 [details]
Patch

[Sam Weinig]

Created attachment 276547 [details]
Patch

[Darin Adler]

Comment on attachment 276547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276547&action=review

> Tools/MiniBrowser/mac/BrowserWindowController.m:212
> +    NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds];
> +    
> +    return rect;

Why the local variable?

[Darin Adler]

Should we port MiniBrowser to Swift at some point?

[Sam Weinig]

(In reply to comment #3)
> Comment on attachment 276547 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276547&action=review
> 
> > Tools/MiniBrowser/mac/BrowserWindowController.m:212
> > +    NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds];
> > +    
> > +    return rect;
> 
> Why the local variable?

I was playing with rect earlier and forgot to fix it. Will fix before landing.

[Sam Weinig]

(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 276547 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=276547&action=review
> > 
> > > Tools/MiniBrowser/mac/BrowserWindowController.m:212
> > > +    NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds];
> > > +    
> > > +    return rect;
> > 
> > Why the local variable?
> 
> I was playing with rect earlier and forgot to fix it. Will fix before
> landing.

Probably. Need to figure out what OSes people are using this on before doing it to make sure it's kosher.

[Sam Weinig]

Committed r199630: <http://trac.webkit.org/changeset/199630>