Bug 156658 - Add support for NSSharingService to MiniBrowser, for no great reasons
Summary: Add support for NSSharingService to MiniBrowser, for no great reasons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-15 22:35 PDT by Sam Weinig
Modified: 2016-04-16 17:10 PDT (History)
1 user (show)

See Also:

Attachments
Patch (18.40 KB, patch)
2016-04-15 22:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (18.17 KB, patch)
2016-04-15 22:39 PDT, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-04-15 22:35:32 PDT 
Add support for NSSharingService to MiniBrowser, for no great reasons
Comment 1 Sam Weinig 2016-04-15 22:38:57 PDT 
Created attachment 276546 [details]
Patch
Comment 2 Sam Weinig 2016-04-15 22:39:27 PDT 
Created attachment 276547 [details]
Patch
Comment 3 Darin Adler 2016-04-15 22:43:33 PDT 
Comment on attachment 276547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276547&action=review

> Tools/MiniBrowser/mac/BrowserWindowController.m:212
> +    NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds];
> +    
> +    return rect;

Why the local variable?
Comment 4 Darin Adler 2016-04-15 22:43:52 PDT 
Should we port MiniBrowser to Swift at some point?
Comment 5 Sam Weinig 2016-04-16 00:21:43 PDT 
(In reply to comment #3)
> Comment on attachment 276547 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276547&action=review
> 
> > Tools/MiniBrowser/mac/BrowserWindowController.m:212
> > +    NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds];
> > +    
> > +    return rect;
> 
> Why the local variable?

I was playing with rect earlier and forgot to fix it. Will fix before landing.
Comment 6 Sam Weinig 2016-04-16 00:22:30 PDT 
(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 276547 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=276547&action=review
> > 
> > > Tools/MiniBrowser/mac/BrowserWindowController.m:212
> > > +    NSRect rect = [self.window convertRectToScreen:self.mainContentView.bounds];
> > > +    
> > > +    return rect;
> > 
> > Why the local variable?
> 
> I was playing with rect earlier and forgot to fix it. Will fix before
> landing.

Probably. Need to figure out what OSes people are using this on before doing it to make sure it's kosher.
Comment 7 Sam Weinig 2016-04-16 17:10:30 PDT 
Committed r199630: <http://trac.webkit.org/changeset/199630>