Bug 156646 - Animometer test could report a NaN
Summary: Animometer test could report a NaN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-15 14:55 PDT by Jon Lee
Modified: 2016-04-15 18:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2016-04-15 15:01 PDT, Jon Lee 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2016-04-15 14:55:01 PDT 
Fix occasional NaN reporting
Comment 1 Jon Lee 2016-04-15 15:01:47 PDT 
Created attachment 276515 [details]
Patch
Comment 2 Said Abou-Hallawa 2016-04-15 15:26:48 PDT 
Comment on attachment 276515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=276515&action=review

Looks good to me. Unofficial r=me.

> PerformanceTests/ChangeLog:13
> +                This occurs because we never get out of the first tier, so this._lastTierComplexity is undefined.

Nit: stray white space.
Comment 3 Jon Lee 2016-04-15 18:03:29 PDT 
Committed r199616: <http://trac.webkit.org/changeset/199616>