Bug 156640 – Modern IDB (Blob support): When reading Blobs from the database, grant the Networking process sandbox access to the files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB (Blob support): When reading Blobs from the database, grant the Networking process sandbox access to the files

[Brady Eidson]

Created attachment 276690 [details]
Patch v1

[WebKit Commit Bot]

Attachment 276690 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:130:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:408:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 276690 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=276690&action=review

> Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:420
> +    if (auto handler = m_sandboxExtensionForBlobsCompletionHandlers.take(requestID))
> +        handler(handles);

else ASSERT_NOT_REACHED()?

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 276690 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276690&action=review
> 
> > Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:420
> > +    if (auto handler = m_sandboxExtensionForBlobsCompletionHandlers.take(requestID))
> > +        handler(handles);
> 
> else ASSERT_NOT_REACHED()?

Bizarrely, no! A common trap that can be fallen into in MP-IPC-land

If the DatabaseProcess crashes while a request is outstanding, and then is relaunched to receive completion for this request ID, it will have no record of this request ID, which is fine.

[WebKit Commit Bot]

Comment on attachment 276690 [details]
Patch v1

Clearing flags on attachment: 276690

Committed r199708: <http://trac.webkit.org/changeset/199708>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.