RESOLVED FIXED 156635
Web Automation: provide detailed error messages when an automation command fails 
https://bugs.webkit.org/show_bug.cgi?id=156635
Summary Web Automation: provide detailed error messages when an automation command fails
Blaze Burg
Reported 2016-04-15 12:27:42 PDT
.
Attachments
Proposed Fix (37.56 KB, patch)
2016-04-15 17:09 PDT, Blaze Burg 		darin: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-04-15 12:28:03 PDT
<rdar://problem/25754051>
Blaze Burg
Comment 2 2016-04-15 17:09:56 PDT
Created attachment 276527 [details] Proposed Fix
Blaze Burg
Comment 3 2016-04-15 17:10:17 PDT
Comment on attachment 276527 [details] Proposed Fix Needs to land with corresponding internal patch.
Timothy Hatcher
Comment 4 2016-04-18 07:37:25 PDT
Comment on attachment 276527 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=276527&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:269 > + FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InternalError, "The remote session could not request a new browsing context."); If we are passing these error messages through to the endpoints, should we use "window" instead of "browsing context"? > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:273 > + FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InternalError, "The remote session failed to create a new browsing context."); Ditto.
Blaze Burg
Comment 5 2016-04-18 10:15:58 PDT
Comment on attachment 276527 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=276527&action=review >> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:269 >> + FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InternalError, "The remote session could not request a new browsing context."); > > If we are passing these error messages through to the endpoints, should we use "window" instead of "browsing context"? They currently only go through to endpoints in engineering builds, since most of these errors are programming errors and leak implementation details. So the verbiage is not important IMO.
Timothy Hatcher
Comment 6 2016-04-18 10:40:04 PDT
Comment on attachment 276527 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=276527&action=review >>> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:269 >>> + FAIL_WITH_PREDEFINED_ERROR_AND_DETAILS(InternalError, "The remote session could not request a new browsing context."); >> >> If we are passing these error messages through to the endpoints, should we use "window" instead of "browsing context"? > > They currently only go through to endpoints in engineering builds, since most of these errors are programming errors and leak implementation details. So the verbiage is not important IMO. Okay!
Blaze Burg
Comment 7 2016-04-18 10:45:45 PDT
Committed r199680: <http://trac.webkit.org/changeset/199680>
Note You need to log in before you can comment on or make changes to this bug.