Bug 156627 - Web Inspector: Events in JavaScript & Events timeline have no profile children
Summary: Web Inspector: Events in JavaScript & Events timeline have no profile children
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-15 09:34 PDT by Timothy Hatcher
Modified: 2016-04-24 17:59 PDT (History)
8 users (show)

See Also:

Attachments
Screenshot (109.24 KB, image/png)
2016-04-15 09:34 PDT, Timothy Hatcher 		no flags Details
Screenshot of Call Trees View (79.28 KB, image/png)
2016-04-15 09:37 PDT, Timothy Hatcher 		no flags Details
[Patch] Proposed Fix (4.99 KB, patch)
2016-04-24 14:32 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-04-15 09:34:52 PDT 
Created attachment 276476 [details]
Screenshot

A simple page like daring fireball.net shows unload has children, but expanding it does not show anything. A (program) earlier is the same. See screenshot recorded during page load.

Either these are so fast they have no children and we should not show the disclosure arrow. Or we are missing profile data here.
Comment 1 Radar WebKit Bug Importer 2016-04-15 09:36:18 PDT 
<rdar://problem/25749740>
Comment 2 Timothy Hatcher 2016-04-15 09:37:03 PDT 
Created attachment 276477 [details]
Screenshot of Call Trees View

This is a bug in the Events view, since the Call Trees view has samples for other functions under unload.
Comment 3 Joseph Pecoraro 2016-04-15 10:09:24 PDT 
<rdar://problem/25275724>
Comment 4 Matt Baker 2016-04-24 14:32:22 PDT 
Created attachment 277197 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-04-24 17:59:24 PDT 
Comment on attachment 277197 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 277197

Committed r199971: <http://trac.webkit.org/changeset/199971>
Comment 6 WebKit Commit Bot 2016-04-24 17:59:28 PDT 
All reviewed patches have been landed.  Closing bug.