Bug 156619 - Web Inspector: Cleanup inspector/debugger tests
Summary: Web Inspector: Cleanup inspector/debugger tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-04-14 22:56 PDT by Joseph Pecoraro
Modified: 2016-04-15 10:18 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (34.41 KB, patch)
2016-04-14 23:00 PDT, Joseph Pecoraro 		bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-04-14 22:56:32 PDT 
* SUMMARY
Cleanup inspector/debugger tests

- There is no Debugger.setVariableValue anymore, test can be removed

- Tests that set breakpoints should ensure breakpoints are active.
  - The backend recently changed to only enter interactive debugging when breakpoints are active
  - When run individually, many of these tests fail, they succeed because earlier tests enabled breakpoints via inspector-test
  - This exposes an issue, breakpoints are not getting disabled when the inspector is disconnected
Comment 1 Radar WebKit Bug Importer 2016-04-14 22:56:49 PDT 
<rdar://problem/25743141>
Comment 2 Joseph Pecoraro 2016-04-14 23:00:03 PDT 
Created attachment 276462 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-04-15 09:41:07 PDT 
Comment on attachment 276462 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=276462&action=review

r=me

> LayoutTests/ChangeLog:7
> +

Please include some of your summary from the bug here. Just reading the changelog I had little idea what's going on.

> LayoutTests/inspector/debugger/setVariableValue.html:-11
> -    function runRequestSeries(step) {

RIP, Joe's handcrafted promises.

> Source/JavaScriptCore/ChangeLog:8
> +        While cleaning up the tests it exposed the fact that breakpoints

Oh, I guess the main explanation is here. Never mind then.

> Source/JavaScriptCore/ChangeLog:17
> +2016-04-14  Joseph Pecoraro  <pecoraro@apple.com>

OOPS! Double changelog.
Comment 4 Joseph Pecoraro 2016-04-15 10:18:37 PDT 
<http://trac.webkit.org/changeset/199592>