Bug 156619 – Web Inspector: Cleanup inspector/debugger tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Cleanup inspector/debugger tests

- There is no Debugger.setVariableValue anymore, test can be removed

- Tests that set breakpoints should ensure breakpoints are active.
  - The backend recently changed to only enter interactive debugging when breakpoints are active
  - When run individually, many of these tests fail, they succeed because earlier tests enabled breakpoints via inspector-test
  - This exposes an issue, breakpoints are not getting disabled when the inspector is disconnected

[Radar WebKit Bug Importer]

<rdar://problem/25743141>

[Joseph Pecoraro]

Created attachment 276462 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 276462 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=276462&action=review

r=me

> LayoutTests/ChangeLog:7
> +

Please include some of your summary from the bug here. Just reading the changelog I had little idea what's going on.

> LayoutTests/inspector/debugger/setVariableValue.html:-11
> -    function runRequestSeries(step) {

RIP, Joe's handcrafted promises.

> Source/JavaScriptCore/ChangeLog:8
> +        While cleaning up the tests it exposed the fact that breakpoints

Oh, I guess the main explanation is here. Never mind then.

> Source/JavaScriptCore/ChangeLog:17
> [phone]  Joseph Pecoraro  <[e-mail]>

OOPS! Double changelog.

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/199592>