WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
156609
REGRESSION (
r158956
): Remove vestigial range code in FileReaderLoader class after removing ENABLE(STREAM)
https://bugs.webkit.org/show_bug.cgi?id=156609
Summary
REGRESSION (r158956): Remove vestigial range code in FileReaderLoader class a...
David Kilzer (:ddkilzer)
Reported
2016-04-14 16:12:52 PDT
This code was left behind when ENABLE(STREAM) was removed in November 2013.
Attachments
Patch v1
(3.11 KB, patch)
2016-04-14 16:14 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2016-04-14 16:14:43 PDT
Created
attachment 276446
[details]
Patch v1
David Kilzer (:ddkilzer)
Comment 2
2016-04-14 16:15:32 PDT
Here's where the code was removed for
Bug 123667
: Committed
r158956
: <
http://trac.webkit.org/changeset/158956
>
Brent Fulgham
Comment 3
2016-04-14 16:33:01 PDT
Comment on
attachment 276446
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=276446&action=review
This looks good. r=me.
> Source/WebCore/fileapi/FileReaderLoader.cpp:-65 > - , m_rangeEnd(0)
I would be tempted to convert these to C++11 initializers, but you don't need to do that for this change.
WebKit Commit Bot
Comment 4
2016-04-14 17:23:19 PDT
Comment on
attachment 276446
[details]
Patch v1 Clearing flags on attachment: 276446 Committed
r199569
: <
http://trac.webkit.org/changeset/199569
>
WebKit Commit Bot
Comment 5
2016-04-14 17:23:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug