Bug 156606 - [COCOA] Do not unnecessarily initialize ResourceResponse::m_httpVersion as part of common fields
Summary: [COCOA] Do not unnecessarily initialize ResourceResponse::m_httpVersion as pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-14 16:01 PDT by Chris Dumez
Modified: 2016-04-15 09:44 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.08 KB, patch)
2016-04-14 16:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-04-14 16:01:12 PDT
Do not unnecessarily initialize ResourceResponse::m_httpVersion as part of common fields.

We currently initialize m_httpVersion when calling platformLazyInit(CommonFieldsOnly) even though this is not a common field. The corresponding getter/setter in HTTPResponseBase, call lazyInit(AllFields).
Comment 1 Chris Dumez 2016-04-14 16:03:19 PDT
Created attachment 276445 [details]
Patch
Comment 2 WebKit Commit Bot 2016-04-15 09:44:04 PDT
Comment on attachment 276445 [details]
Patch

Clearing flags on attachment: 276445

Committed r199591: <http://trac.webkit.org/changeset/199591>
Comment 3 WebKit Commit Bot 2016-04-15 09:44:08 PDT
All reviewed patches have been landed.  Closing bug.