Bug 15659 - InlineTextBox does not setStrokeStyle() as needed
Summary: InlineTextBox does not setStrokeStyle() as needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-24 04:05 PDT by Alp Toker
Modified: 2009-02-23 12:15 PST (History)
1 user (show)

See Also:


Attachments
Call context->setStrokeStyle(SolidStroke) (1.20 KB, patch)
2007-10-24 04:07 PDT, Alp Toker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-10-24 04:05:06 PDT
InlineTextBox should setStrokeStyle(SolidStroke) where appropriate, otherwise the old StrokeStyle will be used when drawing underlines for text.

Due to a bug in GraphicsContextCG (which fills rectangles to draw line strokes), this bug does not affect CG graphics, but does affect GraphicsContextCairo.
Comment 1 Alp Toker 2007-10-24 04:07:11 PDT
Created attachment 16834 [details]
Call context->setStrokeStyle(SolidStroke)

I've just added context->setStrokeStyle(SolidStroke) in a few places as proof of concept. This may not cover all cases, and needs testing against the Mac port.
Comment 2 Adam Treat 2009-02-23 12:15:06 PST
This was fixed with r41152 I believe although the workaround in GraphicsContextCairo should probably be removed.