Bug 15658 - Speed up SunSpider by 2.4% by removing checks for isOutOfMemory()
Summary: Speed up SunSpider by 2.4% by removing checks for isOutOfMemory()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-24 03:33 PDT by Eric Seidel (no email)
Modified: 2007-10-24 14:53 PDT (History)
3 users (show)

See Also:


Attachments
fix (5.67 KB, patch)
2007-10-24 03:36 PDT, Eric Seidel (no email)
darin: review-
Details | Formatted Diff | Diff
better fix (should fix both issues raised by darin) (5.68 KB, patch)
2007-10-24 12:05 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-24 03:33:34 PDT
Speed up SunSpider by 2.2% by checks for isOutOfMemory()

See attached patch.
Comment 1 Eric Seidel (no email) 2007-10-24 03:36:21 PDT
Created attachment 16831 [details]
fix
Comment 2 Eric Seidel (no email) 2007-10-24 03:49:12 PDT
Actually now SunSpider is telling me it's 2.4% faster. :)
Comment 3 Darin Adler 2007-10-24 07:47:12 PDT
Comment on attachment 16831 [details]
fix

r=me
Comment 4 Darin Adler 2007-10-24 09:35:31 PDT
Comment on attachment 16831 [details]
fix

This version of the patch isn't quite right. For one thing, once memoryFull is set true, this patch will *never* set it back to false. That was not the old behavior.

For another, we hit an assertion immediately in the debug build because operationInProgress is still true.
Comment 5 Darin Adler 2007-10-24 10:17:05 PDT
We *really* want this fix, but I ran out of time this morning trying to fix the two tiny problems with it and land it.
Comment 6 Eric Seidel (no email) 2007-10-24 12:05:37 PDT
Created attachment 16841 [details]
better fix (should fix both issues raised by darin)
Comment 7 Maciej Stachowiak 2007-10-24 14:36:14 PDT
Comment on attachment 16841 [details]
better fix (should fix both issues raised by darin)

r=me
Comment 8 Eric Seidel (no email) 2007-10-24 14:53:46 PDT
r27001